Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.8] empty unit test csv fixture values default to null (#10117) #10118

Merged
merged 1 commit into from
May 9, 2024
Merged

[Backport 1.8] empty unit test csv fixture values default to null (#10117) #10118

merged 1 commit into from
May 9, 2024

Conversation

MichelleArk
Copy link
Contributor

(cherry picked from commit 55aad32)

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label May 9, 2024
@codecov Codecov
Copy link

codecov bot commented May 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (a59ee80) to head (320a719).

Additional details and impacted files 
@@             Coverage Diff             @@
##           1.8.latest   #10118   +/-   ##
===========================================
  Coverage       88.16%   88.16%           
===========================================
  Files             181      181           
  Lines           22750    22751    +1     
===========================================
+ Hits            20058    20059    +1     
  Misses           2692     2692
Flag Coverage Δ
integration 85.43% <100.00%> (+<0.01%) ⬆️
unit 62.62% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk changed the title empty unit test csv fixture values default to null (#10117) [Backport 1.8] empty unit test csv fixture values default to null (#10117) May 9, 2024
@MichelleArk MichelleArk marked this pull request as ready for review May 9, 2024 14:07
@MichelleArk MichelleArk requested a review from a team as a code owner May 9, 2024 14:07
jtcohen6
jtcohen6 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving backport (Gerda & Peter already approved #10117)

@MichelleArk MichelleArk merged commit 5561e94 into 1.8.latest May 9, 2024
122 checks passed
@MichelleArk MichelleArk deleted the backport-10117-to-1.8.latest branch May 9, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichelleArk @jtcohen6